[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 31 00:44:37 PDT 2018


balazske added a comment.

If `BeginSourceFile` is not called on the diagnostic client object, it is not possible to have compiler warnings or errors that come from the "To" context while importing something (there is some assertion if a source file related warning is to be emitted but no source file is set). In the currently existing tests there is no such case but I have not yet committed tests that produce such warnings (for example ODR violations during import or encounter of unsupported constructs).


Repository:
  rC Clang

https://reviews.llvm.org/D47445





More information about the cfe-commits mailing list