[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 30 11:46:48 PDT 2018


akyrtzi added a comment.

It's not clear to me what kind of issue you are addressing, for example is the unit test hitting an assertion hit without your changes ? Or is there something else ?
Also it would be good to add some documentation comments to clarify what's the use case and when `ASTUnit::beginSourceFile()` should be getting called.


Repository:
  rC Clang

https://reviews.llvm.org/D47445





More information about the cfe-commits mailing list