[PATCH] D45931: [ASTMatchers] Don't garble the profiling output when multiple TU's are processed

Tue May 1 13:28:41 PDT 2018

lebedev.ri added a comment.

In https://reviews.llvm.org/D45931#1083192, @lebedev.ri wrote:

> Thank you for looking at this.
>
> In https://reviews.llvm.org/D45931#1083184, @alexfh wrote:
>
> > From a user's perspective I'd probably prefer a different behavior of checks profiling with multiple translation units: per-file table after each file and an aggregate table at the end.
>
>
> Is this a review note, or a general observation?
>
> I'm sure it could be done, i'm just not //too// sure how useful it would be, since it seems no one before now even noticed that timing with multiple TU's was 'broken'.

Hi @alexfh. Do i need to make those changes or not?
I'd really prefer to have such kind of high-level feedback the sooner the better, to avoid wasting everyone's time.

>> An independent improvement could be to support TSV/CSV output and/or dumping to a file to spare the user from parsing the tables out of the stdout/stderr.
> 
> Yes, and a script to merge those CSV's, would be nice.

Repository:
  rC Clang

https://reviews.llvm.org/D45931