[PATCH] D45931: [ASTMatchers] Don't garble the profiling output when multiple TU's are processed

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 30 11:53:15 PDT 2018


lebedev.ri added a comment.

Thank you for looking at this.

In https://reviews.llvm.org/D45931#1083184, @alexfh wrote:

> From a user's perspective I'd probably prefer a different behavior of checks profiling with multiple translation units: per-file table after each file and an aggregate table at the end.


Is this a review note, or a general observation?

I'm sure it could be done, i'm just not //too// sure how useful it would be, since it seems no one before now even noticed that timing with multiple TU's was 'broken'.

> An independent improvement could be to support TSV/CSV output and/or dumping to a file to spare the user from parsing the tables out of the stdout/stderr.

Yes, and a script to merge those CSV's, would be nice.


Repository:
  rC Clang

https://reviews.llvm.org/D45931





More information about the cfe-commits mailing list