[PATCH] D45931: [ASTMatchers] Don't garble the profiling output when multiple TU's are processed

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 3 10:06:54 PDT 2018


alexfh added a comment.

In https://reviews.llvm.org/D45931#1084503, @lebedev.ri wrote:

> In https://reviews.llvm.org/D45931#1083192, @lebedev.ri wrote:
>
> > Thank you for looking at this.
> >
> > In https://reviews.llvm.org/D45931#1083184, @alexfh wrote:
> >
> > > From a user's perspective I'd probably prefer a different behavior of checks profiling with multiple translation units: per-file table after each file and an aggregate table at the end.
> >
> >
> > Is this a review note, or a general observation?
>


Why not both? ;)

>>> An independent improvement could be to support TSV/CSV output and/or dumping to a file to spare the user from parsing the tables out of the stdout/stderr.
>> 
>> Yes, and a script to merge those CSV's, would be nice.

I'd probably go with a set of features enough for various use cases:
0. don't add any profile merging logic to clang-tidy

1. dump profile after each TU to the screen in the current tabulated format
2. add a flag to specify a file name prefix to dump profile output for each file as CSV
3. (optional) add a script to merge profiles from CSV files and dump as CSV or tabulated (without a script this could be done in a spreadsheet)

WDYT?


Repository:
  rC Clang

https://reviews.llvm.org/D45931





More information about the cfe-commits mailing list