r329445 - Revert "[analyzer] Remove an unused variable"

[George Karpenkov via cfe-commits]

Thanks, didn’t know!

> On Apr 9, 2018, at 9:37 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Best if you can use the SubVersion revision number rather than a git hash when reverting. There's a utility in the LLVM project to help with this (llvm/utils/git-svn/git-svnrevert)
> 
> On Fri, Apr 6, 2018 at 12:16 PM George Karpenkov via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: george.karpenkov
> Date: Fri Apr  6 12:14:05 2018
> New Revision: 329445
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=329445&view=rev <http://llvm.org/viewvc/llvm-project?rev=329445&view=rev>
> Log:
> Revert "[analyzer] Remove an unused variable"
> 
> This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36.
> 
> Removed the wrong variable.
> 
> Modified:
>     cfe/trunk/lib/Analysis/LiveVariables.cpp
> 
> Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff <http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff>
> ==============================================================================
> --- cfe/trunk/lib/Analysis/LiveVariables.cpp (original)
> +++ cfe/trunk/lib/Analysis/LiveVariables.cpp Fri Apr  6 12:14:05 2018
> @@ -381,7 +381,7 @@ void TransferFunctions::VisitBlockExpr(B
>  void TransferFunctions::VisitDeclRefExpr(DeclRefExpr *DR) {
>    const Decl* D = DR->getDecl();
>    bool InAssignment = LV.inAssignment[DR];
> -  if (isa<BindingDecl>(D)) {
> +  if (const auto *BD = dyn_cast<BindingDecl>(D)) {
>      if (!InAssignment)
>        val.liveBindings = LV.BSetFact.add(val.liveBindings, BD);
>    } else if (const auto *VD = dyn_cast<VarDecl>(D)) {
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180409/961ee08c/attachment.html>