<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks, didn’t know!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 9, 2018, at 9:37 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Best if you can use the SubVersion revision number rather than a git hash when reverting. There's a utility in the LLVM project to help with this (llvm/utils/git-svn/git-svnrevert)</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Apr 6, 2018 at 12:16 PM George Karpenkov via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br class="">
Date: Fri Apr 6 12:14:05 2018<br class="">
New Revision: 329445<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329445&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=329445&view=rev</a><br class="">
Log:<br class="">
Revert "[analyzer] Remove an unused variable"<br class="">
<br class="">
This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36.<br class="">
<br class="">
Removed the wrong variable.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Analysis/LiveVariables.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=329445&r1=329444&r2=329445&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/Analysis/LiveVariables.cpp (original)<br class="">
+++ cfe/trunk/lib/Analysis/LiveVariables.cpp Fri Apr 6 12:14:05 2018<br class="">
@@ -381,7 +381,7 @@ void TransferFunctions::VisitBlockExpr(B<br class="">
void TransferFunctions::VisitDeclRefExpr(DeclRefExpr *DR) {<br class="">
const Decl* D = DR->getDecl();<br class="">
bool InAssignment = LV.inAssignment[DR];<br class="">
- if (isa<BindingDecl>(D)) {<br class="">
+ if (const auto *BD = dyn_cast<BindingDecl>(D)) {<br class="">
if (!InAssignment)<br class="">
val.liveBindings = LV.BSetFact.add(val.liveBindings, BD);<br class="">
} else if (const auto *VD = dyn_cast<VarDecl>(D)) {<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>