[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: lib/Driver/Driver.cpp:2267
+        if ((IA->getType() != types::TY_CUDA) &&
+            IA->getType() != types::TY_HIP) {
           // The builder will ignore this input.
----------------
rjmccall wrote:
> The extra parens are weird here.
will remove it.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:263
+    // HIP needs c++11.
+    CC1Args.push_back("-std=c++11");
+    // Skip CUDA includes for HIP.
----------------
Hahnfeld wrote:
> Will this override the user's value, e.g. `-std=c++14`?
No. We will add diagnotics in a separate patch.


https://reviews.llvm.org/D45212