[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 30 14:20:03 PDT 2017
On 28 August 2017 at 17:00, Nico Weber via cfe-commits <
cfe-commits at lists.llvm.org> wrote:
> On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator
> via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>> rsmith added inline comments.
>> Comment at: test/SemaCXX/destructor.cpp:27
>> +#define BE_THE_HEADER
>> +#include __FILE__
>> Do we guarantee that `__FILE__` names a path that can be used to include
>> the current file? In other tests, we add `-include %s` to the `RUN:` line
>> to model this situation.
> `ack 'include __FILE__' test` finds plenty of hits at least, this is a
> somewhat common pattern. (As far as I can remember, introduced by you :-)
> -- I might be misremembering though.)
:) Fair enough. If we already know this works on all buildbots then that's
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits