[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 17:00:51 PDT 2017


On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator
via cfe-commits <cfe-commits at lists.llvm.org> wrote:

> rsmith added inline comments.
>
>
> ================
> Comment at: test/SemaCXX/destructor.cpp:27
> +#define BE_THE_HEADER
> +#include __FILE__
> +
> ----------------
> Do we guarantee that `__FILE__` names a path that can be used to include
> the current file? In other tests, we add `-include %s` to the `RUN:` line
> to model this situation.
>

 `ack 'include __FILE__' test` finds plenty of hits at least, this is a
somewhat common pattern. (As far as I can remember, introduced by you :-)
-- I might be misremembering though.)


>
>
> https://reviews.llvm.org/D37235
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170828/cc67e1ea/attachment-0001.html>


More information about the cfe-commits mailing list