<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">rsmith added inline comments.<br>
<br>
<br>
================<br>
Comment at: test/SemaCXX/destructor.cpp:27<br>
<span class="gmail-">+#define BE_THE_HEADER<br>
+#include __FILE__<br>
+<br>
</span>----------------<br>
Do we guarantee that `__FILE__` names a path that can be used to include the current file? In other tests, we add `-include %s` to the `RUN:` line to model this situation.<br></blockquote><div><br></div><div> `ack 'include __FILE__' test` finds plenty of hits at least, this is a somewhat common pattern. (As far as I can remember, introduced by you :-) -- I might be misremembering though.)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
<a href="https://reviews.llvm.org/D37235" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D37235</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>