[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

[Sam McCall via Phabricator via cfe-commits]

sammccall updated this revision to Diff 90990.
sammccall added a comment.

Address review comments. Uncovered two bugs:

- accidentally casting through bool: EXPECT_EQ(1, hasSymbol) was a lie
- we were double counting uses of typedefs where the underlying type was built in, because qualType(hasDeclaration) stops at the typedef in this case.


https://reviews.llvm.org/D30685

Files:
  include-fixer/IncludeFixer.cpp
  include-fixer/find-all-symbols/FindAllMacros.cpp
  include-fixer/find-all-symbols/FindAllSymbols.cpp
  include-fixer/find-all-symbols/SymbolInfo.cpp
  include-fixer/find-all-symbols/SymbolInfo.h
  include-fixer/tool/ClangIncludeFixer.cpp
  test/include-fixer/Inputs/fake_yaml_db.yaml
  test/include-fixer/Inputs/merge/a.yaml
  test/include-fixer/Inputs/merge/b.yaml
  test/include-fixer/merge.test
  unittests/include-fixer/IncludeFixerTest.cpp
  unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30685.90990.patch
Type: text/x-patch
Size: 33620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170308/f0d57728/attachment-0001.bin>