[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 8 02:37:08 PST 2017


sammccall marked an inline comment as done.
sammccall added a comment.

In https://reviews.llvm.org/D30685#695284, @hokein wrote:

> > We may want to track individual occurrences (line number, full type info)
> >  and aggregate this during mapreduce, but that's not done here.
>
> Seems reasonable. So we will introduce a new structure to track these occurrences? Or reuse the `SymbolInfo::Signals`?


These aren't really signals, but they're more like map-value than map-key. I suspect it's another new struct. Fortunately we don't actually need it yet.


https://reviews.llvm.org/D30685





More information about the cfe-commits mailing list