[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

> We may want to track individual occurrences (line number, full type info)
>  and aggregate this during mapreduce, but that's not done here.

Seems reasonable. So we will introduce a new structure to track these occurrences? Or reuse the `SymbolInfo::Signals`?



================
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:45
 
-  bool hasSymbol(const SymbolInfo &Symbol) const {
+  int hasSymbol(const SymbolInfo &Symbol) const {
     auto it = Symbols.find(Symbol);
----------------
 With the change, the name is not a suitable name as it returns to the number of times. Maybe rename it ("symbolSeenTimes"). The same below. 


https://reviews.llvm.org/D30685