[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

Asiri Rathnayake via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 8 09:26:16 PST 2017


rmaprath updated this revision to Diff 87669.
rmaprath added a comment.

Sorry for the delay, I've updated the patch with all the comments addressed.

@EricWF: Got one question before I commit: The `sleep_for` function in the dylib (`thread.cpp`) is now quite small. Is there a particular reason to keep it there? I was wondering if we should move that bit to the `<thread>` header altogether.


https://reviews.llvm.org/D29630

Files:
  include/__threading_support
  src/thread.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29630.87669.patch
Type: text/x-patch
Size: 3192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170208/31a08c7a/attachment.bin>


More information about the cfe-commits mailing list