[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

[Eric Fiselier via Phabricator via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM. @joerg has raised some legitimate concerns about the Windows implementation. However that shouldn't hold this cleanup up, since the implementation is preexisting.



================
Comment at: include/__threading_support:354
+   using namespace chrono;
+   seconds s = duration_cast<seconds>(ns);
+   timespec ts;
----------------
Reserved names are needed for `s` and `ns` `ts` and the like now that this is in a header.


https://reviews.llvm.org/D29630