[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 8 09:28:00 PST 2017
EricWF added a comment.
In https://reviews.llvm.org/D29630#670873, @rmaprath wrote:
> Sorry for the delay, I've updated the patch with all the comments addressed.
>
> @EricWF: Got one question before I commit: The `sleep_for` function in the dylib (`thread.cpp`) is now quite small. Is there a particular reason to keep it there? I was wondering if we should move that bit to the `<thread>` header altogether.
Removing the definition in the dylib would be ABI breaking.
https://reviews.llvm.org/D29630
More information about the cfe-commits
mailing list