[libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

[Saleem Abdulrasool via cfe-commits]

Can you file a PR for changing this to internal visibility please?  I think
that we could probably do that in the unstable ABI versioning in fact.

On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: bogner
> Date: Mon Jan 30 19:26:09 2017
> New Revision: 293581
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293581&view=rev
> Log:
> Revert "Adorn __call_once_proxy with `inline` and
> `_LIBCPP_INLINE_VISIBILITY`"
>
> While this change didn't really hurt, it does lead to spurious
> warnings about not being able to override weak symbols if you end up
> linking objects built with this change to ones built without it.
> Furthermore, since __call_once_proxy is called indirectly anyway it
> doesn't actually inline ever.
>
> Longer term, it would probably make sense to give this symbol internal
> visibility instead.
>
> This reverts r291497
>
> Modified:
>     libcxx/trunk/include/mutex
>
> Modified: libcxx/trunk/include/mutex
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/
> mutex?rev=293581&r1=293580&r2=293581&view=diff
> ============================================================
> ==================
> --- libcxx/trunk/include/mutex (original)
> +++ libcxx/trunk/include/mutex Mon Jan 30 19:26:09 2017
> @@ -559,7 +559,6 @@ public:
>  #endif
>
>  template <class _Fp>
> -inline _LIBCPP_INLINE_VISIBILITY
>  void
>  __call_once_proxy(void* __vp)
>  {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170130/0db424fa/attachment.html>