[libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"
Hans Wennborg via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 31 08:52:55 PST 2017
Merged to 4.0 as discussed on PR31782.
On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: bogner
> Date: Mon Jan 30 19:26:09 2017
> New Revision: 293581
> URL: http://llvm.org/viewvc/llvm-project?rev=293581&view=rev
> Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"
> While this change didn't really hurt, it does lead to spurious
> warnings about not being able to override weak symbols if you end up
> linking objects built with this change to ones built without it.
> Furthermore, since __call_once_proxy is called indirectly anyway it
> doesn't actually inline ever.
> Longer term, it would probably make sense to give this symbol internal
> visibility instead.
> This reverts r291497
> Modified: libcxx/trunk/include/mutex
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/mutex?rev=293581&r1=293580&r2=293581&view=diff
> --- libcxx/trunk/include/mutex (original)
> +++ libcxx/trunk/include/mutex Mon Jan 30 19:26:09 2017
> @@ -559,7 +559,6 @@ public:
> template <class _Fp>
> -inline _LIBCPP_INLINE_VISIBILITY
> __call_once_proxy(void* __vp)
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
More information about the cfe-commits