<div dir="ltr">Can you file a PR for changing this to internal visibility please?  I think that we could probably do that in the unstable ABI versioning in fact.<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bogner<br>
Date: Mon Jan 30 19:26:09 2017<br>
New Revision: 293581<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293581&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=293581&view=rev</a><br>
Log:<br>
Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"<br>
<br>
While this change didn't really hurt, it does lead to spurious<br>
warnings about not being able to override weak symbols if you end up<br>
linking objects built with this change to ones built without it.<br>
Furthermore, since __call_once_proxy is called indirectly anyway it<br>
doesn't actually inline ever.<br>
<br>
Longer term, it would probably make sense to give this symbol internal<br>
visibility instead.<br>
<br>
This reverts r291497<br>
<br>
Modified:<br>
    libcxx/trunk/include/mutex<br>
<br>
Modified: libcxx/trunk/include/mutex<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/mutex?rev=293581&r1=293580&r2=293581&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/include/<wbr>mutex?rev=293581&r1=293580&r2=<wbr>293581&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/include/mutex (original)<br>
+++ libcxx/trunk/include/mutex Mon Jan 30 19:26:09 2017<br>
@@ -559,7 +559,6 @@ public:<br>
 #endif<br>
<br>
 template <class _Fp><br>
-inline _LIBCPP_INLINE_VISIBILITY<br>
 void<br>
 __call_once_proxy(void* __vp)<br>
 {<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>