[PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 29 18:12:59 PDT 2015


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good. Please fix the patch and I can commit it for you.


================
Comment at: clang-tidy/utils/IncludeSorter.cpp:289
@@ +288,3 @@
+IncludeSorter::IncludeStyle
+IncludeSorter::toIncludeStyle(const std::string &Value) {
+  return Value == "llvm" ? IS_LLVM : IS_Google;
----------------
Did you forget to update the name here?


http://reviews.llvm.org/D12839





More information about the cfe-commits mailing list