[PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

Felix Berger via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 29 16:25:35 PDT 2015


flx updated this revision to Diff 36049.
flx marked 3 inline comments as done.
flx added a comment.

I had to convert the line endings of mis-move-constructor-init.cpp to unix style otherwise the test would not correctly work. This took a long time to debug since the checks failed complaining that error messages that look exactly the same didn't match.

Let me know if this needs to be converted back to DOS line endings, but it looks like most other tests have unix line endings.


http://reviews.llvm.org/D12839

Files:
  clang-tidy/misc/MoveConstructorInitCheck.cpp
  clang-tidy/misc/MoveConstructorInitCheck.h
  clang-tidy/modernize/PassByValueCheck.cpp
  clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
  clang-tidy/utils/CMakeLists.txt
  clang-tidy/utils/IncludeSorter.cpp
  clang-tidy/utils/IncludeSorter.h
  clang-tidy/utils/Matchers.h
  clang-tidy/utils/TypeTraits.cpp
  clang-tidy/utils/TypeTraits.h
  docs/clang-tidy/checks/misc-move-constructor-init.rst
  test/clang-tidy/misc-move-constructor-init.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12839.36049.patch
Type: text/x-patch
Size: 20220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150929/f4995053/attachment-0001.bin>


More information about the cfe-commits mailing list