[PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 29 18:17:46 PDT 2015


alexfh added a comment.

In http://reviews.llvm.org/D12839#256179, @flx wrote:

> I had to convert the line endings of mis-move-constructor-init.cpp to unix style otherwise the test would not correctly work. This took a long time to debug since the checks failed complaining that error messages that look exactly the same didn't match.
>
> Let me know if this needs to be converted back to DOS line endings, but it looks like most other tests have unix line endings.


All source and test files should have svn:eol-style=native property set to avoid this kind of an issue. I have no idea why is it not done on all llvm/clang sources.


http://reviews.llvm.org/D12839





More information about the cfe-commits mailing list