[PATCH] D12579: AST: simplify handling of the mangling

[Saleem Abdulrasool via cfe-commits]

compnerd added inline comments.

================
Comment at: lib/AST/Mangle.cpp:139
@@ -149,2 +138,3 @@
 
-  Out << '\01';
+  // shouldMangleCXXName lies sometimes for the MS-ABI, so check the CC mangling
+  // when targeting MS-ABI (it doesnt consider CC which take precedence over
----------------
majnemer wrote:
> What do you mean by lie?  Are we patching over a bug in the MS mangler?
The shouldMangleCXXName seems to be insufficient of a check for the MS ABI case, and will return `false` for cases where it shouldn't.  The comment is to clear up the reason for the

    CC = CM_Other && TI.getCXXABI() == TargetCXXABI::Microsoft

check which we need to add.


http://reviews.llvm.org/D12579