[PATCH] D12579: AST: simplify handling of the mangling

[Reid Kleckner via cfe-commits]

rnk added inline comments.

================
Comment at: lib/AST/Mangle.cpp:142
@@ +141,3 @@
+  // language).
+  if (MCXX || (CC == CM_Other && TI.getCXXABI() == TargetCXXABI::Microsoft))
+    return mangleCXXName(D, Out);
----------------
TI.getCXXABI().isMicrosoft() is better than the == check.

================
Comment at: lib/AST/Mangle.cpp:156-161
@@ -155,8 +151,3 @@
 
-  if (!MCXX)
-    Out << D->getIdentifier()->getName();
-  else if (const ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(D))
-    mangleObjCMethodName(OMD, Out);
-  else
-    mangleCXXName(D, Out);
 
----------------
This looks like a functional change for Itanium. The old code was intentionally structured so that Itanium also had C calling convention mangling on Windows.


http://reviews.llvm.org/D12579