[PATCH] D12579: AST: simplify handling of the mangling

[David Majnemer via cfe-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/AST/Mangle.cpp:130
@@ +129,3 @@
+  // ObjectiveC/C++ cannot support alternate calling conventions due to method
+  // dispatch.  Honour the mangling irrespective of the annotations.
+  if (const ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(D))
----------------
Please use the American spelling, "honor."

================
Comment at: lib/AST/Mangle.cpp:131
@@ +130,3 @@
+  // dispatch.  Honour the mangling irrespective of the annotations.
+  if (const ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(D))
+    return mangleObjCMethodName(OMD, Out);
----------------
The type is obvious here, please use `auto *`.

================
Comment at: lib/AST/Mangle.cpp:139
@@ -149,2 +138,3 @@
 
-  Out << '\01';
+  // shouldMangleCXXName lies sometimes for the MS-ABI, so check the CC mangling
+  // when targeting MS-ABI (it doesnt consider CC which take precedence over
----------------
What do you mean by lie?  Are we patching over a bug in the MS mangler?

================
Comment at: lib/AST/Mangle.cpp:140
@@ +139,3 @@
+  // shouldMangleCXXName lies sometimes for the MS-ABI, so check the CC mangling
+  // when targeting MS-ABI (it doesnt consider CC which take precedence over
+  // language).
----------------
doesn't


http://reviews.llvm.org/D12579