[PATCH] Use 'override/final' instead of 'virtual' for overridden methods
Alexander Kornienko
alexfh at google.com
Fri Apr 10 18:41:51 PDT 2015
================
Comment at: include/clang/Analysis/AnalysisContext.h:327
@@ -326,3 +326,3 @@
public:
- ~ScopeContext() {}
+ ~ScopeContext() override {}
----------------
dblaikie wrote:
> Do we have a clang-tidy warning for explicitly writing default definitions of functions? Would love to just not have this sort of code written at all.
Would you prefer to remove all empty or default destructors defined inline in derived classes? No, we don't have this check yet.
http://reviews.llvm.org/D8926
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list