[PATCH] Use 'override/final' instead of 'virtual' for overridden methods

[David Blaikie]

On Apr 10, 2015 6:41 PM, "Alexander Kornienko" <alexfh at google.com> wrote:
>
> ================
> Comment at: include/clang/Analysis/AnalysisContext.h:327
> @@ -326,3 +326,3 @@
>  public:
> -  ~ScopeContext() {}
> +  ~ScopeContext() override {}
>
> ----------------
> dblaikie wrote:
> > Do we have a clang-tidy warning for explicitly writing default
definitions of functions? Would love to just not have this sort of code
written at all.
> Would you prefer to remove all empty or default destructors defined
inline in derived classes? No, we don't have this check yet.

Only if you feel like doing that (consider this precommit review approval
if you wanted it) - this override change is fine even if that dtor work
isn't done.

>
> http://reviews.llvm.org/D8926
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150410/4663d621/attachment.html>