[PATCH] Use 'override/final' instead of 'virtual' for overridden methods
David Blaikie
dblaikie at gmail.com
Fri Apr 10 16:41:11 PDT 2015
Looks good to me.
Looks like we missed a bunch of 'override' in Clang in general, great to put it in and remove the redundant virtual at the same time.
================
Comment at: include/clang/Analysis/AnalysisContext.h:327
@@ -326,3 +326,3 @@
public:
- ~ScopeContext() {}
+ ~ScopeContext() override {}
----------------
Do we have a clang-tidy warning for explicitly writing default definitions of functions? Would love to just not have this sort of code written at all.
http://reviews.llvm.org/D8926
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list