[patch] Enable column information by default

[Diego Novillo]

On Thu Jul 10 2014 at 4:00:12 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Thu, Jul 10, 2014 at 3:55 PM, Diego Novillo <dnovillo at google.com>
> wrote:
> > David,
> >
> > I ran the testsuite in the gdb bot that you pointed me at. It showed the
> > same failures that you had reproduced:
> >
> >          FAIL: gdb.base/skip.exp: step after disabling 3 (3)
> >          FAIL: gdb.reverse/step-precsave.exp: reverse step out of called
> fn
> >          FAIL: gdb.reverse/step-precsave.exp: reverse next over call
> >          FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
> >          FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
> >          FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
> >          FAIL: gdb.reverse/step-reverse.exp: reverse step out of called
> fn
> >          FAIL: gdb.reverse/step-reverse.exp: reverse next over call
> >          FAIL: gdb.reverse/step-reverse.exp: reverse step test 1
> >          FAIL: gdb.reverse/step-reverse.exp: reverse next test 1
> >          FAIL: gdb.reverse/step-reverse.exp: reverse next test 2
> >
> > But every single one of these failures are not present in gdb trunk.
>
> So they all actually produce PASS results with the same test file, or
> just these results are not present? or that the test has changed in
> some way?




> (did you try running the same test file from the
> clang-tests-external repository, but with GDB ToT, or just manually
> executing the steps?)
>

None of the above. I ran the gdb testsuite on gdb trunk and looked up these
entries. The gdb.base/skip.exp failure shows as PASS in trunk:

PASS: gdb.base/skip.exp: step after disabling 3 (3)

All the others are even more annoying. They fail in trunk with gcolumn-info
AND gno-column-info. My current theory is that they are flaky and we were
just lucking out in 7.5. I'm tempted to file a bug and refer to it in the
xfail message.


Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140710/0675cb71/attachment.html>