[patch] Enable column information by default

[David Blaikie]

On Thu, Jul 10, 2014 at 3:55 PM, Diego Novillo <dnovillo at google.com> wrote:
> David,
>
> I ran the testsuite in the gdb bot that you pointed me at. It showed the
> same failures that you had reproduced:
>
>          FAIL: gdb.base/skip.exp: step after disabling 3 (3)
>          FAIL: gdb.reverse/step-precsave.exp: reverse step out of called fn
>          FAIL: gdb.reverse/step-precsave.exp: reverse next over call
>          FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
>          FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
>          FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
>          FAIL: gdb.reverse/step-reverse.exp: reverse step out of called fn
>          FAIL: gdb.reverse/step-reverse.exp: reverse next over call
>          FAIL: gdb.reverse/step-reverse.exp: reverse step test 1
>          FAIL: gdb.reverse/step-reverse.exp: reverse next test 1
>          FAIL: gdb.reverse/step-reverse.exp: reverse next test 2
>
> But every single one of these failures are not present in gdb trunk.

So they all actually produce PASS results with the same test file, or
just these results are not present? or that the test has changed in
some way? (did you try running the same test file from the
clang-tests-external repository, but with GDB ToT, or just manually
executing the steps?)

>The
> easiest approach for now is to xfail them until a new gdb is tracked by the
> bot.
>
> Is this patch to clang-tests-external OK?

Yep, totally looks right - maybe, if you like, could specify a
revision or release version in which these issues are fixed (in the
xfail messages) so we know when these are relevant and not.

- David

>
>
> Thanks. Diego.
>
> On Wed Jul 09 2014 at 6:28:04 PM, Diego Novillo <dnovillo at google.com> wrote:
>>
>> This patch implements my proposal to turn column information by
>> default. Some background and discussion at:
>>
>> http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/074290.html
>>
>> David, as we discussed offline, I did not see any regressions in the
>> gdb testsuite on gdb's trunk. I will try with the instructions you
>> gave me for gdb 7.5 tomorrow.
>>
>> This also updates the documentation and some tests that relied on the
>> lack of column information. Some tests had column information in the
>> expected output, but it was wrong (the tsan tests). Others were using
>> the driver to execute.
>>
>> Tested on x86_64. Anything else I should test?
>>
>>
>> Thanks.  Diego.