[patch] Enable column information by default

[Diego Novillo]

David,

I ran the testsuite in the gdb bot that you pointed me at. It showed the
same failures that you had reproduced:

         FAIL: gdb.base/skip.exp: step after disabling 3 (3)
         FAIL: gdb.reverse/step-precsave.exp: reverse step out of called fn
         FAIL: gdb.reverse/step-precsave.exp: reverse next over call
         FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
         FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
         FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
         FAIL: gdb.reverse/step-reverse.exp: reverse step out of called fn
         FAIL: gdb.reverse/step-reverse.exp: reverse next over call
         FAIL: gdb.reverse/step-reverse.exp: reverse step test 1
         FAIL: gdb.reverse/step-reverse.exp: reverse next test 1
         FAIL: gdb.reverse/step-reverse.exp: reverse next test 2

But every single one of these failures are not present in gdb trunk. The
easiest approach for now is to xfail them until a new gdb is tracked by the
bot.

Is this patch to clang-tests-external OK?


Thanks. Diego.

On Wed Jul 09 2014 at 6:28:04 PM, Diego Novillo <dnovillo at google.com> wrote:

> This patch implements my proposal to turn column information by
> default. Some background and discussion at:
>
> http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/074290.html
>
> David, as we discussed offline, I did not see any regressions in the
> gdb testsuite on gdb's trunk. I will try with the instructions you
> gave me for gdb 7.5 tomorrow.
>
> This also updates the documentation and some tests that relied on the
> lack of column information. Some tests had column information in the
> expected output, but it was wrong (the tsan tests). Others were using
> the driver to execute.
>
> Tested on x86_64. Anything else I should test?
>
>
> Thanks.  Diego.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140710/248bf167/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 00gdb-xfails.diff
Type: application/octet-stream
Size: 2842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140710/248bf167/attachment.obj>