[PATCH] PR15664 - -frewrite-includes doesn't handle Windows UTF-8 BOM
l.lunak at centrum.cz
Wed Nov 27 13:21:39 PST 2013
On Wednesday 27 of November 2013, Reid Kleckner wrote:
> Looks fine, the lexer does this, as well as other places. Can you add an
> -frewrite-includes test for this? I think you can rewrite, then run -cc1
> -verify with // expected-no-diagnostics or something like that.
Oh, did I forget :) ? Updated the patch to the attached version, pushed as
r195877 and made sure the BOM had made it in.
> On Wed, Nov 27, 2013 at 3:50 AM, Lubos Lunak <l.lunak at centrum.cz> wrote:
> > Hello,
> > could somebody please review the attached simple patch for PR15664?
> > The patch intentionally doesn't do anything fancy except simply removing
> > the
> > BOM (which should be unnecessary for UTF-8 anyway). I'm not sure what
> > handling other UTF encodings would exactly require, and it's surely
> > better to
> > keep the compilation obviously fail for whoever will possibly run into
> > that one day and provide a testcase.
> > --
> > Lubos Lunak
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1853 bytes
Desc: not available
More information about the cfe-commits