[PATCH] PR15664 - -frewrite-includes doesn't handle Windows UTF-8 BOM

[Alp Toker]

While trying to get this test working, I noticed that removing the 
trailing EOF from rewrite-includes-bom.c causes a lexer crash:

Assertion failed: (PP && "Cannot reset token mode without a 
preprocessor"), function resetExtendedTokenMode, file 
/Users/alp/Projects/llvm-work/upstream/clang/lib/Lex/Lexer.cpp, line 134.

Looks like a pre-existing problem though, will file a PR.

Alp.

On 27/11/2013 19:31, Reid Kleckner wrote:
> Looks fine, the lexer does this, as well as other places.  Can you add 
> an -frewrite-includes test for this?  I think you can rewrite, then 
> run -cc1 -verify with // expected-no-diagnostics or something like that.
>
>
> On Wed, Nov 27, 2013 at 3:50 AM, Lubos Lunak <l.lunak at centrum.cz 
> <mailto:l.lunak at centrum.cz>> wrote:
>
>
>      Hello,
>
>      could somebody please review the attached simple patch for PR15664?
>
>      The patch intentionally doesn't do anything fancy except simply
>     removing the
>     BOM (which should be unnecessary for UTF-8 anyway). I'm not sure what
>     handling other UTF encodings would exactly require, and it's
>     surely better to
>     keep the compilation obviously fail for whoever will possibly run
>     into that
>     one day and provide a testcase.
>
>     --
>      Lubos Lunak
>
>     _______________________________________________
>     cfe-commits mailing list
>     cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts