[PATCH] PR15664 - -frewrite-includes doesn't handle Windows UTF-8 BOM
rnk at google.com
Wed Nov 27 11:31:48 PST 2013
Looks fine, the lexer does this, as well as other places. Can you add an
-frewrite-includes test for this? I think you can rewrite, then run -cc1
-verify with // expected-no-diagnostics or something like that.
On Wed, Nov 27, 2013 at 3:50 AM, Lubos Lunak <l.lunak at centrum.cz> wrote:
> could somebody please review the attached simple patch for PR15664?
> The patch intentionally doesn't do anything fancy except simply removing
> BOM (which should be unnecessary for UTF-8 anyway). I'm not sure what
> handling other UTF encodings would exactly require, and it's surely better
> keep the compilation obviously fail for whoever will possibly run into that
> one day and provide a testcase.
> Lubos Lunak
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits