[PATCH] PR15664 - -frewrite-includes doesn't handle Windows UTF-8 BOM

Lubos Lunak l.lunak at centrum.cz
Wed Nov 27 03:50:13 PST 2013


 could somebody please review the attached simple patch for PR15664?

 The patch intentionally doesn't do anything fancy except simply removing the 
BOM (which should be unnecessary for UTF-8 anyway). I'm not sure what 
handling other UTF encodings would exactly require, and it's surely better to 
keep the compilation obviously fail for whoever will possibly run into that 
one day and provide a testcase.

 Lubos Lunak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-strip-UTF-8-BOM-in-frewrite-includes-PR-15664.patch
Type: text/x-diff
Size: 976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131127/0c8248be/attachment.patch>

More information about the cfe-commits mailing list