r193027 - Add isFirstDecl to DecBase too and use it instead of getPreviousDecl() == 0.

[Sean Silva]

On Fri, Oct 18, 2013 at 11:21 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 18 October 2013 23:19, Sean Silva <silvas at purdue.edu> wrote:
> > +  /// \brief Returns true if this is the first declaration.
> > +  bool isFirstDecl() const {
> >
> > This comment doesn't add anything. First declaration of what? in what?
>
> It seemed clear given the context. It is the same comment in
> Redeclarable.h. Any suggestions?
>

"... in it's redeclaration chain" maybe? Otherwise, just delete the
comment; saying just "is the first declaration" while having a name
"isFirstDecl" is completely redundant.

-- Sean Silva



>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131019/75504184/attachment.html>