r193027 - Add isFirstDecl to DecBase too and use it instead of getPreviousDecl() == 0.
Rafael EspĂndola
rafael.espindola at gmail.com
Sat Oct 19 06:12:40 PDT 2013
r193036
On 19 October 2013 00:39, Sean Silva <silvas at purdue.edu> wrote:
>
>
>
> On Fri, Oct 18, 2013 at 11:21 PM, Rafael EspĂndola
> <rafael.espindola at gmail.com> wrote:
>>
>> On 18 October 2013 23:19, Sean Silva <silvas at purdue.edu> wrote:
>> > + /// \brief Returns true if this is the first declaration.
>> > + bool isFirstDecl() const {
>> >
>> > This comment doesn't add anything. First declaration of what? in what?
>>
>> It seemed clear given the context. It is the same comment in
>> Redeclarable.h. Any suggestions?
>
>
> "... in it's redeclaration chain" maybe? Otherwise, just delete the comment;
> saying just "is the first declaration" while having a name "isFirstDecl" is
> completely redundant.
>
> -- Sean Silva
>
>
>>
>>
>> Cheers,
>> Rafael
>
>
More information about the cfe-commits
mailing list