<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Oct 18, 2013 at 11:21 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 18 October 2013 23:19, Sean Silva <<a href="mailto:silvas@purdue.edu">silvas@purdue.edu</a>> wrote:<br>
> + /// \brief Returns true if this is the first declaration.<br>
> + bool isFirstDecl() const {<br>
><br>
> This comment doesn't add anything. First declaration of what? in what?<br>
<br>
</div>It seemed clear given the context. It is the same comment in<br>
Redeclarable.h. Any suggestions?<br></blockquote><div><br></div><div>"... in it's redeclaration chain" maybe? Otherwise, just delete the comment; saying just "is the first declaration" while having a name "isFirstDecl" is completely redundant.</div>
<div><br></div><div>-- Sean Silva</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
</blockquote></div><br></div></div>