r188332 - ObjectiveC [QoI] issue warning if an element of an nsarray

[jahanian]

On Aug 13, 2013, at 4:53 PM, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Tue, Aug 13, 2013 at 4:44 PM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> Author: fjahanian
> Date: Tue Aug 13 18:44:55 2013
> New Revision: 188332
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=188332&view=rev
> Log:
> ObjectiveC [QoI] issue warning if an element of an nsarray
> expresison is a concatenated nsstring element.
> // rdar://14303083
> 
> Modified:
>     cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>     cfe/trunk/lib/Sema/SemaExprObjC.cpp
>     cfe/trunk/test/SemaObjC/objc-array-literal.m
> 
> 
> +def warn_concatenated_nsarray_literal : Warning<
> +  "concatenated nsstring literal for an nsarray expression">,
> +  InGroup<ObjCStringConcatenation>;
> 
> Capitalization?  Also, you might want to say "(possibly missing comma)" or something like that so it's obvious why this matters.

Makes sense. In r188335.
- Fariborz

> 
> -Eli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130813/e8bf0f31/attachment.html>