<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 13, 2013, at 4:53 PM, Eli Friedman <<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">On Tue, Aug 13, 2013 at 4:44 PM, Fariborz Jahanian<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;">Author: fjahanian<br>Date: Tue Aug 13 18:44:55 2013<br>New Revision: 188332<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=188332&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=188332&view=rev</a><br>Log:<br>ObjectiveC [QoI] issue warning if an element of an nsarray<br>expresison is a concatenated nsstring element.<br>//<span class="Apple-converted-space"> </span><a href="rdar://14303083">rdar://14303083</a><br><br>Modified:<br> <span class="Apple-converted-space"> </span>cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br> <span class="Apple-converted-space"> </span>cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br> <span class="Apple-converted-space"> </span>cfe/trunk/lib/Sema/SemaExprObjC.cpp<br> <span class="Apple-converted-space"> </span>cfe/trunk/test/SemaObjC/objc-array-literal.m<br><br><br>+def warn_concatenated_nsarray_literal : Warning<<br>+ "concatenated nsstring literal for an nsarray expression">,<br>+ InGroup<ObjCStringConcatenation>;<br></blockquote><div><br></div><div>Capitalization? Also, you might want to say "(possibly missing comma)" or something like that so it's obvious why this matters.</div></div></div></div></div></blockquote><div dir="auto"><br></div>Makes sense. In r<span style="font-family: Menlo; font-size: 11px;">188335.</span></div><div dir="auto"><font face="Menlo"><span style="font-size: 11px;">- Fariborz</span></font></div><div dir="auto"><font face="Menlo"><span style="font-size: 11px;"><br></span></font><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>-Eli</div></div></div></div></div></blockquote></div><br></body></html>