r188332 - ObjectiveC [QoI] issue warning if an element of an nsarray

[Eli Friedman]

On Tue, Aug 13, 2013 at 4:44 PM, Fariborz Jahanian <fjahanian at apple.com>wrote:

> Author: fjahanian
> Date: Tue Aug 13 18:44:55 2013
> New Revision: 188332
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188332&view=rev
> Log:
> ObjectiveC [QoI] issue warning if an element of an nsarray
> expresison is a concatenated nsstring element.
> // rdar://14303083
>
> Modified:
>     cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>     cfe/trunk/lib/Sema/SemaExprObjC.cpp
>     cfe/trunk/test/SemaObjC/objc-array-literal.m
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=188332&r1=188331&r2=188332&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Tue Aug 13 18:44:55
> 2013
> @@ -552,6 +552,7 @@ def ObjCCocoaAPI : DiagGroup<"objc-cocoa
>    ]>;
>
>  def ObjCStringComparison : DiagGroup<"objc-string-compare">;
> +def ObjCStringConcatenation : DiagGroup<"objc-string-concatenation">;
>  def ObjCLiteralComparison : DiagGroup<"objc-literal-compare", [
>      ObjCStringComparison
>    ]>;
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=188332&r1=188331&r2=188332&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue Aug 13
> 18:44:55 2013
> @@ -1898,6 +1898,9 @@ def warn_missing_atsign_prefix : Warning
>  def warn_objc_string_literal_comparison : Warning<
>    "direct comparison of a string literal has undefined behavior">,
>    InGroup<ObjCStringComparison>;
> +def warn_concatenated_nsarray_literal : Warning<
> +  "concatenated nsstring literal for an nsarray expression">,
> +  InGroup<ObjCStringConcatenation>;
>

Capitalization?  Also, you might want to say "(possibly missing comma)" or
something like that so it's obvious why this matters.

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130813/49f3b1c3/attachment.html>