<div dir="ltr">On Tue, Aug 13, 2013 at 4:44 PM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Tue Aug 13 18:44:55 2013<br>
New Revision: 188332<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=188332&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=188332&view=rev</a><br>
Log:<br>
ObjectiveC [QoI] issue warning if an element of an nsarray<br>
expresison is a concatenated nsstring element.<br>
// rdar://14303083<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
    cfe/trunk/lib/Sema/SemaExprObjC.cpp<br>
    cfe/trunk/test/SemaObjC/objc-array-literal.m<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=188332&r1=188331&r2=188332&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=188332&r1=188331&r2=188332&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Tue Aug 13 18:44:55 2013<br>
@@ -552,6 +552,7 @@ def ObjCCocoaAPI : DiagGroup<"objc-cocoa<br>
   ]>;<br>
<br>
 def ObjCStringComparison : DiagGroup<"objc-string-compare">;<br>
+def ObjCStringConcatenation : DiagGroup<"objc-string-concatenation">;<br>
 def ObjCLiteralComparison : DiagGroup<"objc-literal-compare", [<br>
     ObjCStringComparison<br>
   ]>;<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=188332&r1=188331&r2=188332&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=188332&r1=188331&r2=188332&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue Aug 13 18:44:55 2013<br>
@@ -1898,6 +1898,9 @@ def warn_missing_atsign_prefix : Warning<br>
 def warn_objc_string_literal_comparison : Warning<<br>
   "direct comparison of a string literal has undefined behavior">,<br>
   InGroup<ObjCStringComparison>;<br>
+def warn_concatenated_nsarray_literal : Warning<<br>
+  "concatenated nsstring literal for an nsarray expression">,<br>
+  InGroup<ObjCStringConcatenation>;<br></blockquote><div><br></div><div>Capitalization?  Also, you might want to say "(possibly missing comma)" or something like that so it's obvious why this matters.</div>
<div><br></div><div>-Eli</div></div></div></div>