r178015 - Fix uninitialized read of CalleeWithThisReturn.

[Alexey Samsonov]

On Tue, Mar 26, 2013 at 9:29 PM, John McCall <rjmccall at apple.com> wrote:

> On Mar 26, 2013, at 6:44 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com>
> wrote:
> > Author: eugenis
> > Date: Tue Mar 26 08:44:29 2013
> > New Revision: 178015
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=178015&view=rev
> > Log:
> > Fix uninitialized read of CalleeWithThisReturn.
> >
> > CalleeWithThisReturn can be left initialized if HasThisReturn() is false.
> > This change reverses the order of checks in EmitFunctionEpilog such that
> > CalleeWithThisReturn is only examined when it has a meaningful value.
>
> Checking CalleeWithThisReturn is much faster than making that call.  We
> should just initialize CalleeWithThisReturn properly in the constructor.
>

See also http://llvm.org/bugs/show_bug.cgi?id=15598


>
> John.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130327/c361ef57/attachment.html>