<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Tue, Mar 26, 2013 at 9:29 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On Mar 26, 2013, at 6:44 AM, Evgeniy Stepanov <<a href="mailto:eugeni.stepanov@gmail.com">eugeni.stepanov@gmail.com</a>> wrote:<br>
> Author: eugenis<br>
> Date: Tue Mar 26 08:44:29 2013<br>
> New Revision: 178015<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=178015&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=178015&view=rev</a><br>
> Log:<br>
> Fix uninitialized read of CalleeWithThisReturn.<br>
><br>
> CalleeWithThisReturn can be left initialized if HasThisReturn() is false.<br>
> This change reverses the order of checks in EmitFunctionEpilog such that<br>
> CalleeWithThisReturn is only examined when it has a meaningful value.<br>
<br>
</div>Checking CalleeWithThisReturn is much faster than making that call. We<br>
should just initialize CalleeWithThisReturn properly in the constructor.<br></blockquote><div><br></div><div style>See also <a href="http://llvm.org/bugs/show_bug.cgi?id=15598">http://llvm.org/bugs/show_bug.cgi?id=15598</a></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
John.<br>
</font></span><div class=""><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>