r178015 - Fix uninitialized read of CalleeWithThisReturn.

John McCall rjmccall at apple.com
Tue Mar 26 10:29:04 PDT 2013


On Mar 26, 2013, at 6:44 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com> wrote:
> Author: eugenis
> Date: Tue Mar 26 08:44:29 2013
> New Revision: 178015
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=178015&view=rev
> Log:
> Fix uninitialized read of CalleeWithThisReturn.
> 
> CalleeWithThisReturn can be left initialized if HasThisReturn() is false.
> This change reverses the order of checks in EmitFunctionEpilog such that
> CalleeWithThisReturn is only examined when it has a meaningful value.

Checking CalleeWithThisReturn is much faster than making that call.  We
should just initialize CalleeWithThisReturn properly in the constructor.

John.



More information about the cfe-commits mailing list