[cfe-commits] [PATCH] Tagging NSLog/NSLogv with the __NSString__ format instead of __printf__ format

Ted Kremenek kremenek at apple.com
Mon Jan 23 23:07:20 PST 2012

On Jan 21, 2012, at 3:49 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:

> I have a first patch that add NSLog/NSLogv to Builtins.def, but instead of adding a new letter to define NSString format attribute, I enhance the AddKnownFunctionAttributes function to automatically specify "NSString" format instead of "printf" format when the format parameter is an objc object.
> This patch also remove trailing '/' in front of objc header names in Builtins.def. It prevents message like "include </obj/objc-exception.h>" in diagnostics.

Looks good, but can we separate this into two separate commits?  They are entirely orthogonal, and a patch is easier to review when it doesn't blur together a bunch of changes for disjoint functionality into a single commit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120123/42e83515/attachment.html>

More information about the cfe-commits mailing list