<html><head></head><body bgcolor="#FFFFFF"><div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">On Jan 21, 2012, at 3:49 AM, Jean-Daniel Dupas <<a href="mailto:devlists@shadowlab.org">devlists@shadowlab.org</a>> wrote:</span></div><div><br></div><blockquote type="cite"><div><div>I have a first patch that add NSLog/NSLogv to Builtins.def, but instead of adding a new letter to define NSString format attribute, I enhance the <span class="Apple-style-span" style="font-family: Menlo; font-size: 11px; ">AddKnownFunctionAttributes</span><span class="Apple-style-span" style="background-color: transparent;"> function to automatically specify "NSString" format inste</span>ad of "printf" format when the format parameter is an objc object.</div></div><div><br></div><div>This patch also remove trailing '/' in front of objc header names in Builtins.def. It prevents message like "include </obj/objc-exception.h>" in diagnostics.</div></blockquote><br><div></div><div>Looks good, but can we separate this into two separate commits? They are entirely orthogonal, and a patch is easier to review when it doesn't blur together a bunch of changes for disjoint functionality into a single commit.</div></body></html>