[cfe-commits] [PATCH] Tagging NSLog/NSLogv with the __NSString__ format instead of __printf__ format

[Jean-Daniel Dupas]

Le 24 janv. 2012 à 08:07, Ted Kremenek a écrit :

> On Jan 21, 2012, at 3:49 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:
> 
>> I have a first patch that add NSLog/NSLogv to Builtins.def, but instead of adding a new letter to define NSString format attribute, I enhance the AddKnownFunctionAttributes function to automatically specify "NSString" format instead of "printf" format when the format parameter is an objc object.
>> 
>> This patch also remove trailing '/' in front of objc header names in Builtins.def. It prevents message like "include </obj/objc-exception.h>" in diagnostics.
> 
> Looks good, but can we separate this into two separate commits?  They are entirely orthogonal, and a patch is easier to review when it doesn't blur together a bunch of changes for disjoint functionality into a single commit.


Of course we can. If you confirm they are fine, I will commit them.

-- Jean-Daniel



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120124/da03d830/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1-trailing.patch
Type: application/octet-stream
Size: 4223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120124/da03d830/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120124/da03d830/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2-nslog.patch
Type: application/octet-stream
Size: 3658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120124/da03d830/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120124/da03d830/attachment-0002.html>