[cfe-commits] Patch to save category name loc in ObjCCategoryImplDecl

[jahanian]

On Dec 8, 2011, at 11:14 AM, Jason Haslam wrote:

> Hmm… okay. I guess that the only justification that I have is that we use it in our IDE to point to the location of the category implementation (e.g. when the user right clicks on the category name in the interface declaration and selects 'Edit Implementation'). There's no other use in clang itself.
We have couple of locations you may use:

ObjCCategoryImplDecl(DeclContext *DC, IdentifierInfo *Id,
                       ObjCInterfaceDecl *classInterface,
                       SourceLocation nameLoc, SourceLocation atStartLoc)

- Fariborz

> 
> Jason
> 
> 
> On Dec 8, 2011, at 11:33 AM, jahanian wrote:
> 
>> We don't want to increase size of AST nodes unless there is justification for it.
>> Please provide the completed patch showing what it is used for.
>> 
>> - Fariborz
>> 
>> On Dec 8, 2011, at 9:34 AM, Jason Haslam wrote:
>> 
>>> This small patch saves the SourceLocation of the category name in ObjCCategoryImplDecl.
>>> 
>>> Jason
>>> 
>>> <category_impl_name_loc.diff>_______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111208/f6945465/attachment.html>